Add support iceberg parquet predicate pushdown with iceberg column id #19066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we have a test to check this problem? I found we don't have enough test about iceberg nested type and schema evolution. @findinpath |
homar
reviewed
Sep 25, 2023
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
👋 @Heltman @findinpath and @homar could you please collaborate on the test needs for this PR to move it forward. |
findinpath
reviewed
Jan 11, 2024
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergPageSourceProvider.java
Show resolved
Hide resolved
|
@Heltman pls add a test for your changes / reuse the test I suggested and also rebase on Thank you very much for your contribution. |
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergPageSourceProvider.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergPageSourceProvider.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergPageSourceProvider.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
iceberg-parquet-predicate-pushdown-by-id
branch
from
2427995 to
4b7f6da
Compare
raunaqmorarka
force-pushed
the
iceberg-parquet-predicate-pushdown-by-id
branch
from
4b7f6da to
05f81ee
Compare
raunaqmorarka
approved these changes
Jan 11, 2024
findinpath
approved these changes
Jan 11, 2024
|
Sorry I don't check email. I'm glad this issue is resolved. Thanks for @findinpath and all members. |
|
Awesome work on completing this together @findinpath @Heltman and @raunaqmorarka |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18855.
IcebergPageSourceProvider.getParquetTupleDomainget domain by column name. When column renamed in iceberg, this result is empty. We should use iceberg column id to match parquet column instead.Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: