Add FlatHashStrategyCompiler #19059
Merged
Add FlatHashStrategyCompiler #19059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dain
force-pushed
the
flat-hash-strategy-compiler
branch
2 times, most recently
from
c38cef4 to
d784b54
Compare
dain
force-pushed
the
flat-hash-strategy-compiler
branch
from
d784b54 to
146bd78
Compare
martint
approved these changes
Sep 17, 2023
| } | ||
|
|
||
| flatHashStrategy.readFlat(records, recordOffset + recordValueOffset, variableWidthChunk, variableWidthOffset, blockBuilders); |
There was a problem hiding this comment.
Why is variableWidthOffset no longer needed?
There was a problem hiding this comment.
It was never used. It was a typo in the method signature :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(X) Release notes are required, with the following suggested text: