Fix dictionary encoded page offsets in parquet writer #19032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
requested review from
alexjo2144,
sopel39,
findepi and
findinpath
sopel39
approved these changes
Sep 13, 2023
When dictionary is present, dictionary_page_offset should be populated and data_page_offset should be offset of first data page. Setting these values correctly allows the parquet reader to avoid reading excess data in PredicateUtils#readDictionaryPage for checking if a predicate can prune a row group based on dictionary values.
raunaqmorarka
force-pushed
the
pqr-fix-offset
branch
from
2562cae to
a07eb87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When dictionary is present, dictionary_page_offset should be populated and data_page_offset should be
offset of first data page.
Setting these values correctly allows the parquet reader to avoid reading excess data in
PredicateUtils#readDictionaryPage for checking if a predicate can prune a row group based on dictionary values.
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
(x) Release notes are required, with the following suggested text: