Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken Azure FileSystem Cloud Tests #19006

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix broken Azure FileSystem Cloud Tests #19006

merged 1 commit into from
Sep 12, 2023

Conversation

ebyhr
Copy link
Member

@ebyhr ebyhr commented Sep 12, 2023 •
edited
Loading

Description

CI is broken on master. https://github.com/trinodb/trino/actions/runs/6153633190

The workflow is not valid. .github/workflows/ci.yml (Line: 683, Col: 13): Unrecognized named-value: 'ABFS_FLAT_ACCESS_KEY'. Located at position 249 within expression: false && contains(matrix.modules, 'trino-filesystem-azure') && contains(matrix.profile, 'cloud-tests') && (env.CI_SKIP_SECRETS_PRESENCE_CHECKS != '' || env.ABFS_BLOB_ACCOUNT != '' || env.ABFS_BLOB_ACCESS_KEY != '' || env.ABFS_FLAT_ACCOUNT != '' || ABFS_FLAT_ACCESS_KEY != '' || ABFS_ACCOUNT != '' || ABFS_ACCESS_KEY != '')

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Sep 12, 2023
@ebyhr
Copy link
Member Author

ebyhr commented Sep 12, 2023

Going to merge as lib/trino-filesystem-azure, cloud-tests already passed.

@ebyhr ebyhr merged commit fa08135 into master Sep 12, 2023
@ebyhr ebyhr deleted the ebi/ci-broken branch September 12, 2023 04:31
@github-actions github-actions bot added this to the 427 milestone Sep 12, 2023
@colebow colebow mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wendigo wendigo wendigo approved these changes

@findepi findepi Awaiting requested review from findepi

@losipiuk losipiuk Awaiting requested review from losipiuk

@Praveen2112 Praveen2112 Awaiting requested review from Praveen2112

@hashhar hashhar Awaiting requested review from hashhar

Assignees
No one assigned
Labels
cla-signed
Milestone
427
Development

Successfully merging this pull request may close these issues.
2 participants
@ebyhr @wendigo