Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace hdp2.6 and cdh5.15 with hdp3.1 #18931

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Conversation

nineinchnick
Copy link
Member

@nineinchnick nineinchnick commented Sep 5, 2023

Description

Run all product tests on HDP 3.1 instead of HDP 2.6. This is needed for #17520 because Temurin JDK 21 is built with a newer glibc that's not available on CentOS 6 used as the base image for HDP 2.6.

Requires trinodb/docker-images#172 and trinodb/docker-images#177

Fixes #1652

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@nineinchnick nineinchnick changed the title [WIP] Replace hdp2.6 with hdp3.1 [WIP] Replace hdp2.6 and cdh5.15 with hdp3.1 Sep 12, 2023
@nineinchnick nineinchnick changed the title [WIP] Replace hdp2.6 and cdh5.15 with hdp3.1 Replace hdp2.6 and cdh5.15 with hdp3.1 Sep 12, 2023
@nineinchnick nineinchnick marked this pull request as ready for review September 12, 2023 14:17
@nineinchnick nineinchnick force-pushed the drop-hdp2.6 branch 2 times, most recently from f7abdc9 to 7c60e19 Compare September 12, 2023 14:21
@nineinchnick
Copy link
Member Author

The Hive connector docs say that:

Apache Hadoop HDFS 2.x and 3.x are supported.

Should I also drop 2.x from there?

@wendigo
Copy link
Contributor

wendigo commented Sep 12, 2023

I've released docker-images v86. Can you update first commit to it?

@wendigo
Copy link
Contributor

wendigo commented Sep 13, 2023

Please rearrange commits:

  1. Rename singlenode-hdp3 test env to better reflect its usage
  2. Disable renewing Kerberos tickets when running against KDC on CentOS7
  3. Squash into single commit (move testing to HDP 3.1):
    1. Upgrade docker-images to version 86
    2. Replace hdp2.6 with hdp3.1
    3. Run KMS product tests on HDP3.1
    4. Remove testing on Hive2 (HDP2.6)
    5. Move Tempto configuration for hive3 as defaults
  4. Remove ConfigHdp3 since it's same as the default config

@wendigo
Copy link
Contributor

wendigo commented Sep 13, 2023

Just a single test failing:

Screenshot 2023-09-13 at 13 39 09

Almost there 🎉

Copy link
Contributor

@wendigo wendigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not merge yet :)

@wendigo wendigo merged commit bd6a4dc into trinodb:master Sep 13, 2023
@github-actions github-actions bot added this to the 427 milestone Sep 13, 2023
@nineinchnick nineinchnick deleted the drop-hdp2.6 branch September 14, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hive Hive connector
Development

Successfully merging this pull request may close these issues.

Create product test environment with HDP and KMS
3 participants