Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize column mapping mode tests #18882

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Optimize column mapping mode tests #18882

merged 2 commits into from
Sep 14, 2023

Conversation

pajaks
Copy link
Member

@pajaks pajaks commented Aug 31, 2023 •
edited by ebyhr
Loading

In order to reduce execution time instead of execute all possible combinations some scenarios are selected.

Description

Relates to #18805

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.

@cla-bot cla-bot bot added the cla-signed label Aug 31, 2023
@ebyhr
Copy link
Member

ebyhr commented Aug 31, 2023

Pushed an empty commit since build-pt failed. https://github.com/trinodb/trino/actions/runs/6035850480/job/16377032749?pr=18882

@ebyhr
Copy link
Member

ebyhr commented Sep 1, 2023

/test-with-secrets sha=00b41a3cc090804fbc3e55487c9e70c47253db6f

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/6048254951

@ebyhr
Copy link
Member

ebyhr commented Sep 4, 2023

Just rebased on master to resolve conflicts.

@pajaks pajaks marked this pull request as ready for review September 4, 2023 07:38
@pajaks pajaks requested review from ebyhr and findinpath September 4, 2023 07:38
findinpath
findinpath reviewed Sep 4, 2023
View reviewed changes
...uct-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeColumnMappingMode.java Show resolved Hide resolved
...uct-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeColumnMappingMode.java Show resolved Hide resolved
...uct-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeColumnMappingMode.java Show resolved Hide resolved
...uct-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeColumnMappingMode.java Outdated Show resolved Hide resolved
...uct-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeColumnMappingMode.java Show resolved Hide resolved
...uct-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeColumnMappingMode.java
@Flaky(issue = DATABRICKS_COMMUNICATION_FAILURE_ISSUE, match = DATABRICKS_COMMUNICATION_FAILURE_MATCH)
public void testDeltaSpecialCharacterColumnNamesWithColumnMappingMode(String mode)
public void testDeltaSpecialCharacterColumnNamesWithColumnMappingModeId()
{
testSpecialCharacterColumnNamesWithColumnMappingMode(tableName -> onDelta().executeQuery("" +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testSpecialCharacterColumnNamesWithColumnMappingMode can probably be an integration test with a resource table

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do this in separate PR if thats ok.

...uct-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeColumnMappingMode.java Show resolved Hide resolved
...uct-tests/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeColumnMappingMode.java Outdated Show resolved Hide resolved
@github-actions github-actions bot added the delta-lake Delta Lake connector label Sep 5, 2023
@ebyhr
Copy link
Member

ebyhr commented Sep 7, 2023

/test-with-secrets sha=6c76874175ec8a41a6efdcd1fce87293f26069b3

@github-actions
Copy link

github-actions bot commented Sep 7, 2023 •
edited
Loading

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/6106998215

findinpath
findinpath reviewed Sep 12, 2023
View reviewed changes
Copy link
Contributor

@findinpath findinpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % comments

@findinpath findinpath requested a review from ebyhr September 12, 2023 08:45
@ebyhr
Copy link
Member

ebyhr commented Sep 14, 2023

/test-with-secrets sha=f645bed402d07c979cb4fd8dec31220bf9b5f4f4

@github-actions
Copy link

github-actions bot commented Sep 14, 2023 •
edited
Loading

The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/6183444835

@ebyhr ebyhr merged commit e35c20b into trinodb:master Sep 14, 2023
@github-actions github-actions bot added this to the 427 milestone Sep 14, 2023
@colebow colebow mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@findinpath findinpath findinpath approved these changes

Assignees

@pajaks pajaks

Labels
cla-signed delta-lake Delta Lake connector
Milestone
427
Development

Successfully merging this pull request may close these issues.
3 participants
@pajaks @ebyhr @findinpath