Fix MAP and ARRAY flat write #18874
Merged
Fix MAP and ARRAY flat write #18874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
reviewed
Aug 31, 2023
electrum
approved these changes
Aug 31, 2023
The previous code was adjusting the variable offset by the written fixed size for each value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The MAP and ARRAY types were incorrectly adjusting the pointer for the variable width data by the fixed width size of the type. Since the variable width and fixed with data are kept in different sections of the flat record, the adjustment is not needed and causes failures.
Fixes #18863
Release notes
(X) Release notes are required, with the following suggested text: