Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NPE for spatial left join #18866

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Fix NPE for spatial left join #18866

merged 1 commit into from
Aug 30, 2023

Conversation

martint
Copy link
Member

@martint martint commented Aug 30, 2023

The failure started happening with the update to fastutil 8.5.12 in 5e9bb46

Fixes #18860

Release notes

(x) Release notes are required, with the following suggested text:

# General
* Fix failure when performing an outer join involving geospatial functions in the join clause. ({issue}`18860`)

The failure started happening with the update to fastutil 8.5.12 in 5e9bb46
@wendigo
Copy link
Contributor

wendigo commented Aug 30, 2023

Seems like it was the only occurrence left:

sift 'to.*Array\(null\)' -x java
core/trino-main/src/main/java/io/trino/operator/PagesRTreeIndex.java:        return matchingPositions.toIntArray(null);

I've missed that during the upgrade. Sorry :(

@martint martint merged commit bbdef06 into trinodb:master Aug 30, 2023
@martint martint deleted the issue-18860 branch August 30, 2023 19:18
@github-actions github-actions bot added this to the 426 milestone Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Regression: Queries fail with INTERNAL ERROR since 423
2 participants