Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the delta resource files to meaningful directory names #18847

Merged

Conversation

findinpath
Copy link
Contributor

@findinpath findinpath commented Aug 29, 2023

Description

Place the content corresponding to delta tables used for testing
purposes in directories having names corresponding to the medium
in which the delta table content has been created:

  • databricks73
  • databricks104
  • databricks122
  • databricks131
  • deltalake
  • trino410

Preparation PR for #18538

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Aug 29, 2023
@findinpath findinpath added the no-release-notes This pull request does not require release notes entry label Aug 29, 2023
@github-actions github-actions bot added tests:hive delta-lake Delta Lake connector labels Aug 29, 2023
@findinpath findinpath changed the title Rename databricks resource directory to databricks73 Move the delta resource files to meaningful directory names Aug 29, 2023
Place the content corresponding to delta tables used for testing
purposes in directories having names corresponding to the medium
in which the delta table content has been created:

- databricks73
- databricks104
- databricks122
- databricks131
- deltalake
@findinpath findinpath force-pushed the findinpath/delta-lake-databricks-resources branch from 5ebc57c to db64350 Compare August 29, 2023 14:18
@findinpath findinpath self-assigned this Aug 30, 2023
@findinpath findinpath requested review from findepi and ebyhr August 30, 2023 11:09
@losipiuk
Copy link
Member

/test-with-secrets sha=db64350a78611cf33ec4719bdd546edf7f3584e0

@github-actions
Copy link

The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/6024202433

@findepi findepi merged commit 1aca030 into trinodb:master Aug 30, 2023
@github-actions github-actions bot added this to the 426 milestone Aug 30, 2023
@ebyhr
Copy link
Member

ebyhr commented Aug 31, 2023

Some javadoc mentioning resouce path got broken:
Screenshot 2023-08-31 at 15 12 52

@findinpath findinpath mentioned this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed delta-lake Delta Lake connector no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

5 participants