Fix reading large SequenceFile, RCFile, or Avro files #18837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
approved these changes
Aug 28, 2023
|
@electrum can we have a test for it? |
|
I'm not sure how to test this other than generating a 2GB+ file, which would negatively impact the CI, and doesn't seem to be worth the cost. |
raunaqmorarka
approved these changes
Aug 29, 2023
dain
approved these changes
Aug 30, 2023
findepi
reviewed
Aug 30, 2023
| @@ -230,10 +232,14 @@ public int read() | |||
| public long skip(long length) | |||
| throws IOException | |||
| { | |||
| if (length <= 0) { | |||
| return 0; | |||
There was a problem hiding this comment.
for length == 0, it's obvious.
why also for length < 0? is it worth explanatory comment?
There was a problem hiding this comment.
This is the behavior specified in the Javadoc and in the default implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
(x) Release notes are required, with the following suggested text:
Fixes #17890