Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch Ignite client to work with JDK21 #18833

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

nineinchnick
Copy link
Member

Description

Per the discussion in apache/ignite#10764, the earliest we can expect a new release is by the end of the current year. Apply the patch to the current Ignite version so Trino can be built on JDK 21.

Same approach as in #13108

Tested manually using Temurin 21 Early Access.

Additional context and related issues

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Aug 28, 2023
@nineinchnick nineinchnick requested a review from wendigo August 28, 2023 11:21
@wendigo
Copy link
Contributor

wendigo commented Aug 28, 2023

@nineinchnick please split this change into three commits:

  • first adds a module with the original, formatted GridUnsafe class
  • second backports a fix to GridUnsafe class
  • third switched trino-ignite to use shaded module

@nineinchnick
Copy link
Member Author

@nineinchnick please split this change into three commits:

* first adds a module with the original, formatted `GridUnsafe` class

* second backports a fix to `GridUnsafe` class

* third switched `trino-ignite` to use shaded module

The commit with the original GridUnsafe won't compile, and we check every commit for that in the CI.

@wendigo
Copy link
Contributor

wendigo commented Aug 28, 2023

@nineinchnick original, formatted and fixed (assert)

@nineinchnick nineinchnick force-pushed the ignite-patched branch 2 times, most recently from 02dd6a0 to e7e2189 Compare August 28, 2023 13:09
@wendigo
Copy link
Contributor

wendigo commented Aug 29, 2023

There is a typo in the second commit: Path instead of patch.

Please also change third commit title to Use patched Ignite client library or Switch to patched Ignite client library

Other than that LGTM. I'll merge when you push the updated commit titles.

@wendigo wendigo merged commit 325a7e8 into trinodb:master Aug 29, 2023
@github-actions github-actions bot added this to the 426 milestone Aug 29, 2023
@nineinchnick nineinchnick deleted the ignite-patched branch May 27, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants