-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch Ignite client to work with JDK21 #18833
Conversation
lib/trino-ignite-patched/src/main/java/org/apache/ignite/shaded/internal/util/GridUnsafe.java
Show resolved
Hide resolved
@nineinchnick please split this change into three commits:
|
lib/trino-ignite-patched/src/main/java/org/apache/ignite/shaded/internal/util/GridUnsafe.java
Show resolved
Hide resolved
The commit with the original |
@nineinchnick original, formatted and fixed (assert) |
02dd6a0
to
e7e2189
Compare
There is a typo in the second commit: Path instead of patch. Please also change third commit title to Other than that LGTM. I'll merge when you push the updated commit titles. |
e7e2189
to
f5c0b73
Compare
Description
Per the discussion in apache/ignite#10764, the earliest we can expect a new release is by the end of the current year. Apply the patch to the current Ignite version so Trino can be built on JDK 21.
Same approach as in #13108
Tested manually using Temurin 21 Early Access.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: