Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update testcontainers to 1.19.0 #18807

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Update testcontainers to 1.19.0 #18807

merged 1 commit into from
Aug 25, 2023

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Aug 25, 2023

No release notes needed

@cla-bot cla-bot bot added the cla-signed label Aug 25, 2023
@wendigo wendigo requested a review from kokosing August 25, 2023 08:43
ebyhr
ebyhr reviewed Aug 25, 2023
View reviewed changes
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org.testcontainers.containers.ClickHouseContainer which is used in TestingClickHouseServer is deprecated now. Could you replace it with org.testcontainers.clickhouse.ClickHouseContainer?

@wendigo
Copy link
Contributor Author

wendigo commented Aug 25, 2023

@ebyhr Yeah, I saw that one but decided to do it as a follow-up

@wendigo wendigo merged commit 6569cbc into trinodb:master Aug 25, 2023
@wendigo wendigo deleted the serafin/testcontainers-1190 branch August 25, 2023 10:52
@github-actions github-actions bot added this to the 426 milestone Aug 25, 2023
@colebow colebow mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebyhr ebyhr ebyhr approved these changes

@kokosing kokosing Awaiting requested review from kokosing

Assignees
No one assigned
Labels
cla-signed
Milestone
426
Development

Successfully merging this pull request may close these issues.
2 participants
@wendigo @ebyhr