Fix NPE when checking is materialized hive view #18800
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
approved these changes
Aug 24, 2023
| @@ -183,7 +183,7 @@ public static boolean isTrinoMaterializedView(String tableType, Map<String, Stri | |||
| // https://github.com/trinodb/trino/blame/ff4a1e31fb9cb49f1b960abfc16ad469e7126a64/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java#L898 | |||
| return tableType.equals(VIRTUAL_VIEW.name()) && | |||
| "true".equals(tableParameters.get(PRESTO_VIEW_FLAG)) && | |||
| tableParameters.get(TABLE_COMMENT).equalsIgnoreCase(ICEBERG_MATERIALIZED_VIEW_COMMENT); | |||
| ICEBERG_MATERIALIZED_VIEW_COMMENT.equalsIgnoreCase(tableParameters.get(TABLE_COMMENT)); | |||
There was a problem hiding this comment.
Is it possible to add a test?
Don't we need to fix isTrinoView method as well?
findinpath
reviewed
Aug 31, 2023
| @@ -183,7 +183,7 @@ public static boolean isTrinoMaterializedView(String tableType, Map<String, Stri | |||
| // https://github.com/trinodb/trino/blame/ff4a1e31fb9cb49f1b960abfc16ad469e7126a64/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java#L898 | |||
| return tableType.equals(VIRTUAL_VIEW.name()) && | |||
| "true".equals(tableParameters.get(PRESTO_VIEW_FLAG)) && | |||
| tableParameters.get(TABLE_COMMENT).equalsIgnoreCase(ICEBERG_MATERIALIZED_VIEW_COMMENT); | |||
| ICEBERG_MATERIALIZED_VIEW_COMMENT.equalsIgnoreCase(tableParameters.get(TABLE_COMMENT)); | |||
There was a problem hiding this comment.
|
Superseded by #18876. Thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix NPE when Hive view's table_comment not exists
Additional context and related issues
Fixes #18799
Release notes
(x) Release notes are required, with the following suggested text: