Skip getTableHandle call in information_schema.columns with table filter #18730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When reading `information_schema.columns` with a filter on table name (either `=` or `IN`), the code was doing `getRedirectionAwareTableHandle` call to check whether target table exists. However, the redirected tables are handled in `doListTableColumns` (also catching `TABLE_REDIRECTION_ERROR`), so the call inside `calculatePrefixesWithTableName` is redundant.
findepi
force-pushed
the
findepi/skip-gettablehandle-call-in-information-schema-columns-with-table-filter-2580aa
branch
from
ae2a019 to
25ab369
Compare
kokosing
approved these changes
Aug 29, 2023
ebyhr
approved these changes
Aug 30, 2023
findepi
deleted the
findepi/skip-gettablehandle-call-in-information-schema-columns-with-table-filter-2580aa
branch
findepi
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading
information_schema.columnswith a filter on table name (either=orIN), the code was doinggetRedirectionAwareTableHandlecall to check whether target table exists. However, the redirected tables are handled indoListTableColumns(also catchingTABLE_REDIRECTION_ERROR), so the call insidecalculatePrefixesWithTableNameis redundant.