Revert "Reduce redundant code in procedure declarations" #18619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3c1cc8e. IntelliJ understands reflection getMethod calls, allowing navigation to the method, marking the method as used, code completion for the calls, warning if the method cannot be resolved, etc. Unfortunately, none of this works when the reflection is hidden behind a utility.
dain
approved these changes
Aug 10, 2023
github-actions
bot
added
tests:hive
iceberg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 3c1cc8e.
IntelliJ understands reflection getMethod calls, allowing navigation to the method, marking the method as used, code completion for the calls, warning if the method cannot be resolved, etc. Unfortunately, none of this works when the reflection is hidden behind a utility.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: