Remove redundant QualifiedTablePrefix.matches checks #18607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The case where table name is present is handled earlier in the method (`prefix.asQualifiedObjectName().isPresent()` check). The connector is asked to list entities for given schema (or all entities if schema is `Optional.empty`), thus subsequent check for `prefix.matches` was redundant.
findepi
added
the
no-release-notes
wendigo
approved these changes
Aug 9, 2023
ebyhr
reviewed
Aug 10, 2023
| @@ -529,7 +529,6 @@ public List<QualifiedObjectName> listTables(Session session, QualifiedTablePrefi | |||
| metadata.listTables(connectorSession, prefix.getSchemaName()).stream() | |||
| .map(convertFromSchemaTableName(prefix.getCatalogName())) | |||
| .filter(table -> !isExternalInformationSchema(catalogHandle, table.getSchemaName())) | |||
| .filter(prefix::matches) | |||
There was a problem hiding this comment.
Without this filter, this method may return unmatched tables if the connectors include such objects. I have a small concern to trust the connectors' implementation.
There was a problem hiding this comment.
Sorry, i didn't refresh the page before merging and didn't see the comment.
Such a behavior would be a bug in the connector and such be fixed there.
if we wanted to allow connector to return unfiltered results, that should be documented (and tested).
BTW, we didn't have prefix.matches calls (or equivalent) in eg listTableColumns.
findepi
deleted the
findepi/remove-redundant-qualifiedtableprefix-matches-checks-c0e873
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case where table name is present is handled earlier in the method (
prefix.asQualifiedObjectName().isPresent()check). The connector is asked to list entities for given schema (or all entities if schema isOptional.empty), thus subsequent check forprefix.matcheswas redundant.