Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify boolean expression in QueryPlanner #18604

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

pettyjamesm
Copy link
Member

Description

Removes a (probably) unintentional closing parenthesis in QueryPlanner#orderingScheme to make the logical expression grouping clearer and not rely on && vs || operator precedence.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Aug 9, 2023
@pettyjamesm pettyjamesm requested a review from martint August 9, 2023 13:50
Copy link
Member

@martint martint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@pettyjamesm pettyjamesm merged commit 97a1277 into trinodb:master Aug 10, 2023
@pettyjamesm pettyjamesm deleted the cleanup-ordering-scheme branch August 10, 2023 00:04
@github-actions github-actions bot added this to the 423 milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants