Use tracing for testing ConnectorMetadata invocations #18587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how it's usually written.
findepi
force-pushed
the
findepi/use-tracing-for-testing-connectormetadata-invocations-d26020
branch
3 times, most recently
from
e307447 to
8b6f7fd
Compare
findepi
added
test
no-release-notes
findepi
force-pushed
the
findepi/use-tracing-for-testing-connectormetadata-invocations-d26020
branch
from
8b6f7fd to
2d2c9e7
Compare
It was returning success for things that were not supposed to exist according to schema/table listing.
This refactors `TestInformationSchemaConnector.testMetadataCalls` to leverage `TracingConnectorMetadata` instead of manually performed counts within `CountingMockConnector. Among other things this exposes `listViews` calls which were previously not counted. The differences in expected counts in the test come from the fact how the counting was done previously. For example `MockConnectorMetadata.listTables` calls `listSchemaNames` before `listTables`, so this single metadata call was being recorded as both `listSchemaNames` and `listTables` (zero or more times).
findepi
force-pushed
the
findepi/use-tracing-for-testing-connectormetadata-invocations-d26020
branch
from
2d2c9e7 to
0c117f5
Compare
ebyhr
approved these changes
Aug 9, 2023
findepi
deleted the
findepi/use-tracing-for-testing-connectormetadata-invocations-d26020
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors
TestInformationSchemaConnector.testMetadataCallstoleverage
TracingConnectorMetadatainstead of manually performed countswithin
CountingMockConnector. Among other things this exposeslistViews` calls which were previously not counted.The differences in expected counts in the test come from the fact how
the counting was done previously. For example
MockConnectorMetadata.listTablescallslistSchemaNamesbeforelistTables, so this single metadata call was being recorded as bothlistSchemaNamesandlistTables(zero or more times).Extracted from #18586