Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

POC Expose Pinot metrics #18581

Closed
wants to merge 2 commits into from
Closed

POC Expose Pinot metrics #18581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3822eba
POC- Expose Pinot metrics
ChristianJohnston97 Aug 8, 2023
ed320d1
other metrics
ChristianJohnston97 Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/PinotBrokerPageSource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,11 @@ public long getMemoryUsage()
return 0;
}

@Override
public Metrics getMetrics() {
return new Metrics(pinotClient.getMetrics(session, query));
}

@Override
public void close() {}
}
13 changes: 13 additions & 0 deletions plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/client/PinotClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,19 @@ public Iterator<BrokerResultRow> createResultIterator(ConnectorSession session,
return fromResultTable(response, columnHandles, query.getGroupByClauses());
}

public Map<String, Metric<?>> getMetrics(ConnectorSession session, PinotQueryInfo query)
{
BrokerResponseNative response = submitBrokerQueryJson(session, query);
Map<String, Metric<?>> metrics = ImmutableMap.of(
"numDocsScanned", new LongCount(response.getNumDocsScanned()),
"numSegmentsQueried", new LongCount(response.getNumSegmentsQueried()),
"totalDocs", new LongCount(response.getTotalDocs()),
"numSegmentsProcessed", new LongCount(response.getNumSegmentsProcessed()),
"numSegmentsMatched", new LongCount(response.getNumSegmentsMatched()),
);
return metrics;
}

@VisibleForTesting
public static ResultsIterator fromResultTable(BrokerResponseNative brokerResponse, List<PinotColumnHandle> columnHandles, int groupByClauses)
{
Expand Down