Glue catalog cleanup #18543
Merged
Glue catalog cleanup #18543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unusual for get* methods, this one has important side-effects.
`EntityNotFoundException` is AWS SDK exception, which can be thrown from `glueClient.getTable`. All the remaining code is wrapped in `catch (RuntimeException)`, so couldn't trigger the clause.
findepi
added
the
no-release-notes
findepi
requested review from
electrum,
wendigo,
pettyjamesm,
ebyhr,
alexjo2144 and
findinpath
alexjo2144
approved these changes
Aug 4, 2023
|
cc: @jackye1995 |
wendigo
approved these changes
Aug 5, 2023
ebyhr
approved these changes
Aug 7, 2023
Similar to existing createTable and deleteTable methods
The cache is query-scoped and single query doesn't issue requests requiring invalidation, but this is still good practice.
findepi
force-pushed
the
findepi/glue-catalog-clean
branch
from
a92d8ae to
d8058f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small related cleanups for improving code maintainability in
TrinoGlueCatalog