Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop deprecated optimizer.use-mark-distinct #18540

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Drop deprecated optimizer.use-mark-distinct #18540

merged 1 commit into from
Aug 9, 2023

Conversation

lukasz-stec
Copy link
Member

@lukasz-stec lukasz-stec commented Aug 4, 2023 •
edited
Loading

It has been several months since optimizer.use-mark-distinct property was deprecated (as a part of #15927) so I think we can remove it and rely on the optimizer.mark-distinct-strategy only

Description

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(X ) Release notes are required, with the following suggested text:

# General
* Remove the deprecated `optimizer.use-mark-distinct` configuration property.
  The `optimizer.mark-distinct-strategy`  should be used instead.

@lukasz-stec
Drop deprecated optimizer.use-mark-distinct
b18d380 
Config property `optimizer.use-mark-distinct` and corresponding
session property `use_mark_distinct` are removed.
The `optimizer.mark-distinct-strategy` and `mark_distinct_strategy`
should be used instead.
@cla-bot cla-bot bot added the cla-signed label Aug 4, 2023
@github-actions github-actions bot added the docs label Aug 4, 2023
@lukasz-stec lukasz-stec marked this pull request as ready for review August 4, 2023 16:02
@lukasz-stec lukasz-stec requested review from mosabua and sopel39 August 4, 2023 16:02
mosabua
mosabua approved these changes Aug 4, 2023
View reviewed changes
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs change looks good. I am for removing code for deprecated stuff as well.

docs/src/main/sphinx/admin/properties-optimizer.md Show resolved Hide resolved
@sopel39 sopel39 merged commit 1e7c3cf into trinodb:master Aug 9, 2023
@sopel39 sopel39 mentioned this pull request Aug 9, 2023
Closed
@github-actions github-actions bot added this to the 423 milestone Aug 9, 2023
@colebow colebow mentioned this pull request Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sopel39 sopel39 sopel39 approved these changes

@mosabua mosabua mosabua approved these changes

Assignees
No one assigned
Labels
cla-signed docs
Milestone
423
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasz-stec @mosabua @sopel39