Error Prone 2.21.0, NullableOptional check #18512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No new detections, but some new checkers, all at the WARNING level.
The getter (and field) were converted to `Optional` in commit b2482b4, with the headline: "Remove `@Nullable` usage from ResourceGroupInfo", and the `@Nullable` annotation was removed from the other getter converted, so I assume that one was just a leftover.
ksobolew
changed the title
wendigo
approved these changes
Aug 3, 2023
findepi
reviewed
Aug 3, 2023
ksobolew
force-pushed
the
kudi/error-prone-221-and-optional-checker
branch
from
a0d1ae0 to
9bd4232
Compare
wendigo
approved these changes
Aug 3, 2023
|
Thx @ksobolew |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NullableOptionalAdditional context and related issues
The check enabled is a new one in that release, and it looks like it complements
NullOptionalpretty nicely.Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: