Improve performance when planning multiple window functions #18504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was printing the value from the original query instead of the actual input in the plan. This made it harder to see whether and where some columns were being used.
Instead of planning each window function in a separate WindowNode, group them together as long as they have the same window specification. This helps reduce deep plan trees and simplify the structure of the plan by removing redundant operations (e.g., projections to compute frame bounds, filters to ensure frame bounds are legal, etc.), that make it harder for optimizer rules to match and remove later.
martint
changed the title
dain
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of planning each window function in a separate WindowNode, group them together as long as they have the same window specification.
This helps reduce deep plan trees and simplify the structure of the plan by removing redundant operations (e.g., projections to compute frame bounds, filters to ensure frame bounds are legal, etc.), that make it harder for optimizer rules to match and remove later.
Mitigates #18491
Release notes
(x) Release notes are required, with the following suggested text: