Add diagnostic logging for TrinoS3FileSystem delete #18494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
findinpath
reviewed
Aug 2, 2023
| @@ -695,6 +697,7 @@ else if (deletePrefixResult == DeletePrefixResult.DELETE_KEYS_FAILURE) { | |||
| } | |||
| deleteObject(key + DIRECTORY_SUFFIX); | |||
| } | |||
| // TODO should we return true also when deleteObject() returned false? (currently deleteObject's return value is never used) | |||
There was a problem hiding this comment.
This behavior has been there for over 8 years now - see e0fe1c7
Maybe we should use the outcome of delete actually instead of simply returning true and offer to the users (temporarily for a few releases) a fallback setting to still return true independently of the returned result from S3 on deleting an object.
There was a problem hiding this comment.
i don't want to decide this now in this PR. It's definitely difficult to change fragile things like this.
findinpath
approved these changes
Aug 4, 2023
ebyhr
approved these changes
Aug 7, 2023
findepi
deleted the
findepi/add-diagnostic-logging-for-trinos3filesystem-delete-bc5461
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.