GlueHiveMetastore cleanup #18483
Merged
GlueHiveMetastore cleanup #18483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no mutable state maintained directly by this class.
The method did not follow the contract and was filtering by provided parameter *and* also by table type being `VIRTUAL_VIEW`. This was not user-facing problem because the method is currently used by `TrinoViewHiveMetastore.listViews` only (and the incorrect behavior was introduced together with that class).
`deleteData` is respected within the method.
findepi
force-pushed
the
findepi/glue-ms
branch
from
a96e720 to
b19c2c6
Compare
The stream traversal is done already earlier in the method, reuse.
ebyhr
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.