Create a fault tolerant execution smoke test for trino-redshift
#18480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
reviewed
Aug 1, 2023
findepi
reviewed
Aug 1, 2023
...dshift/src/test/java/io/trino/plugin/redshift/TestRedshiftQueryFailureRecoverySmokeTest.java
Outdated
Show resolved
Hide resolved
findepi
reviewed
Aug 1, 2023
...dshift/src/test/java/io/trino/plugin/redshift/TestRedshiftQueryFailureRecoverySmokeTest.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/trino-redshift-fte-smoke-tests
branch
from
9cfd583 to
0bfd826
Compare
|
/test-with-secrets sha=a16052b87f889b2a271c8f1f3cb1bbc85fdd6fa2 |
Opt for a smoke test to verify basic functionality of a CTAS statement on the `trino-redshift` connector. Running all the fault-tolerant execution tests on the connector can occasionally lead to timeouts due to the random geographical positioning of the Github CI runner in relation to the ephemeral AWS Redshift instance.
findinpath
force-pushed
the
findinpath/trino-redshift-fte-smoke-tests
branch
from
a16052b to
b8c19b0
Compare
|
@findepi pls trigger again the build with secrets |
anusudarsan
approved these changes
Aug 2, 2023
|
/test-with-secrets sha=b8c19b02ed8202abfb7f17246b0915958ab4247c |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/5744938013 |
green |
findepi
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opt for a smoke test to verify basic functionality of a CTAS statement on the
trino-redshiftconnector.Running all the fault tolerant execution tests on the connector can occasionally lead to timeouts due to the random geographical positioning of the Github CI runner in relation to the ephemeral AWS Redshift instance.
Local test run of the fault tolerant smoke tests completed locally in ~ 4 minutes.
Fixes #18446
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: