Enable NarrowCalculation error-prone check #18479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The floor argument is an int.
This mostly matches IntelliJ's `integer multiplication implicitly cast to long` inspection. While places changed do not look like bugs, so can be viewed as false positives, this helps avoid IDE warnings and thus makes spotting problems easier.
findepi
added
the
no-release-notes
findepi
force-pushed
the
findepi/enable-narrowcalculation-error-prone-check-ff0d37
branch
from
679816f to
34bf502
Compare
github-actions
bot
added
jdbc
raunaqmorarka
approved these changes
Aug 7, 2023
ebyhr
approved these changes
Aug 7, 2023
findepi
deleted the
findepi/enable-narrowcalculation-error-prone-check-ff0d37
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mostly matches IntelliJ's
integer multiplication implicitly cast to longinspection. While places changed do not look like bugs, so can be viewed as false positives, this helps avoid IDE warnings and thus makes spotting problems easier.