Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow no compilation warnings in selected modules #18477

Merged
merged 7 commits into from
Aug 2, 2023

Conversation

findepi
Copy link
Member

@findepi findepi commented Aug 1, 2023

Ideally whole codebase would be warnings-free.

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very welcome. Specially because there aren't a lot of suppressions needed in these modules.

@findepi findepi merged commit 9c91ba9 into trinodb:master Aug 2, 2023
@findepi findepi deleted the findepi/warningless branch August 2, 2023 06:45
@github-actions github-actions bot added this to the 423 milestone Aug 2, 2023
@kokosing
Copy link
Member

kokosing commented Aug 2, 2023

Nice!

@kokosing
Copy link
Member

kokosing commented Aug 2, 2023

CC: @ksobolew if you are looking for inspiration in your spare time :)

@ksobolew
Copy link
Contributor

ksobolew commented Aug 2, 2023

Yeah @kokosing, I already saw it and got frustrated with all the different places where something gets deprecated and the instructions on how to replace it are either missing or unusably vague ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants