Enable NarrowingCompoundAssignment error-prone check #18466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
In some places it's `double` and sometimes it's `long`. Since it is integral over time, it should be represented as `double` to avoid numeric overflow.
findepi
force-pushed
the
findepi/enable-narrowingcompoundassignment-error-prone-check-d9fcd2
branch
from
67d58db to
7c32011
Compare
`io.trino.orc.writer.ColumnWriter#getBufferedBytes` returns a `long` even though the amount of buffered bytes should not be more than 2 GB. Use `long` in other places too to avoid numeric overflows.
findepi
force-pushed
the
findepi/enable-narrowingcompoundassignment-error-prone-check-d9fcd2
branch
from
45d4633 to
c63db9b
Compare
In Java, compound assignment with wider type on the right-hand-side is a silent truncation. This enables error-prone check for such cases and refactors code to make it compliant. Some places are updated based solely on the assumption that they weren't incorrect.
findepi
force-pushed
the
findepi/enable-narrowingcompoundassignment-error-prone-check-d9fcd2
branch
from
c63db9b to
1ced132
Compare
ebyhr
approved these changes
Aug 1, 2023
findepi
deleted the
findepi/enable-narrowingcompoundassignment-error-prone-check-d9fcd2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compound assignment with wider type on the right-hand-side is a silent truncation.