Performance improvements for the Delta Lake history system table #18427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjo2144
force-pushed
the
delta/history-table
branch
from
30e3212 to
df1059c
Compare
alexjo2144
changed the title
alexjo2144
force-pushed
the
delta/history-table
branch
from
df1059c to
a7d2ed5
Compare
|
FYI I have a PR opened a few months ago on a related topic - #16192 |
Which I did not review.... sorry for missing it. Should I close this? |
findinpath
reviewed
Jul 28, 2023
...in/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeFileOperations.java
Show resolved
Hide resolved
findinpath
reviewed
Jul 28, 2023
...in/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeFileOperations.java
Show resolved
Hide resolved
My PR is rather outdated. I'm thinking that the idea of an iterator over the transaction log entries is worth pursuing. |
|
Pinned this issue down today, looks like |
alexjo2144
force-pushed
the
delta/history-table
branch
from
a7d2ed5 to
643540b
Compare
findepi
approved these changes
Aug 7, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeHistoryTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeHistoryTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeHistoryTable.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeBasic.java
Outdated
Show resolved
Hide resolved
...in/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeFileOperations.java
Outdated
Show resolved
Hide resolved
alexjo2144
force-pushed
the
delta/history-table
branch
from
643540b to
071ed73
Compare
alexjo2144
force-pushed
the
delta/history-table
branch
from
071ed73 to
ddbc7ce
Compare
The $history table does not need to lead the entire transaction log when a version filter is supplied.
alexjo2144
force-pushed
the
delta/history-table
branch
from
ddbc7ce to
bdbbefc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The $history table does not need to lead the entire transaction log when a version filter is supplied.
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: