Fix query failure due to unused dynamic filters #18385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
requested review from
sopel39,
losipiuk,
findepi,
arhimondr and
martint
and removed request for
losipiuk
raunaqmorarka
force-pushed
the
issue18383
branch
from
65317d2 to
c934768
Compare
arhimondr
approved these changes
Jul 25, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently PushPredicateIntoTableScan/RemoveRedundantPredicateAboveTableScan runs after RemoveUnsupportedDynamicFilters may replace a table scan with dynamic filter with an empty ValuesNode.
This leaves behind unused dynamic filters in the join in FTE mode which cause query failure in
plan validation at DynamicFiltersChecker.
Additional context and related issues
Fixes #18383
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: