Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warning generated by WebUiStaticResource#getRoot #18374

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

okumin
Copy link
Contributor

@okumin okumin commented Jul 21, 2023

Description

Remove the following warning caused by an extra @Path annotation.

pod/trino-coordinator-0: 2023-07-18T14:17:22.055Z	WARN	main	org.glassfish.jersey.internal.Errors	The following warnings have been detected: WARNING: The (sub)resource method getRoot in io.trino.server.ui.WebUiStaticResource contains empty path annotation.

Additional context and related issues

For your information,

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@cla-bot
Copy link

cla-bot bot commented Jul 21, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@okumin
Copy link
Contributor Author

okumin commented Jul 21, 2023

I sent my signed CLA yesterday and am waiting for it to be accepted.

@ebyhr
Copy link
Member

ebyhr commented Aug 4, 2023

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Aug 4, 2023
@cla-bot
Copy link

cla-bot bot commented Aug 4, 2023

The cla-bot has been summoned, and re-checked this pull request!

@okumin okumin changed the title [WIP] Suppress warning generated by WebUiStaticResource#getRoot Suppress warning generated by WebUiStaticResource#getRoot Aug 4, 2023
@okumin okumin marked this pull request as ready for review August 4, 2023 02:41
@okumin
Copy link
Contributor Author

okumin commented Aug 4, 2023

I got this PR to be ready to review

Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No requested change. "Suppress warning ...' might be a little misleading for some developers. When I see only the title, I expect adding @SuppressWarnings annotation or //noinspection comment. We could change to Remove @Path with root to suppress warning ...

@ebyhr ebyhr merged commit e42d22d into trinodb:master Aug 4, 2023
@github-actions github-actions bot added this to the 423 milestone Aug 4, 2023
@okumin okumin deleted the warn-root-path branch August 4, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants