Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracing for AccessControl #18338

Merged

Conversation

findepi
Copy link
Member

@findepi findepi commented Jul 19, 2023

No description provided.

@findepi findepi added the no-release-notes This pull request does not require release notes entry label Jul 19, 2023
@cla-bot cla-bot bot added the cla-signed label Jul 19, 2023
public void checkCanSetUser(Optional<Principal> principal, String userName)
{
Span span = startSpan("checkCanSetUser");
try (var ignored = scopedSpan(span)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we instead introduce scopedStartedSpan(String name) so this code becomes:

try (var ignored = scopedStartedSpan("checkCanSetUser")) {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i copied this from TracingMetadata.
i guess the benefit of current approach is that we can stuck additional information into the scope easier.

@findepi findepi merged commit ee88d44 into trinodb:master Jul 20, 2023
@findepi findepi deleted the findepi/add-tracing-for-accesscontrol-6db7de branch July 20, 2023 08:53
@github-actions github-actions bot added this to the 423 milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

None yet

4 participants