Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use putIdentity method to reduce code duplication #18326

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

findinpath
Copy link
Contributor

Description

Refactoring with the purpose of reducing code duplication.

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jul 18, 2023
@findinpath findinpath added the no-release-notes This pull request does not require release notes entry label Jul 18, 2023
@findinpath findinpath requested review from martint and pajaks July 18, 2023 12:27
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could update the following classes as well:

  • PushAggregationThroughOuterJoin
  • TestPushProjectionThroughExchange
  • TestPushTopNThroughProject

@findinpath findinpath force-pushed the findinpath/use-put-identity branch from c17e07f to 6d09bac Compare July 19, 2023 12:13
@findinpath findinpath requested a review from ebyhr July 19, 2023 12:13
@ebyhr
Copy link
Member

ebyhr commented Jul 19, 2023

@findinpath Could you confirm CI failure?

@findinpath findinpath force-pushed the findinpath/use-put-identity branch from 6d09bac to 13aa093 Compare July 20, 2023 09:46
@findinpath
Copy link
Contributor Author

@findinpath Could you confirm CI failure?

My mistake. Removed one wrong modification.

@findinpath
Copy link
Contributor Author

CI hit #16315

@ebyhr ebyhr merged commit b9f4848 into trinodb:master Jul 20, 2023
@github-actions github-actions bot added this to the 423 milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

3 participants