Test Iceberg operations for information_schema.columns #18300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
no-release-notes
alexjo2144
approved these changes
Jul 14, 2023
alexjo2144
reviewed
Jul 14, 2023
| ImmutableMultiset.builder() | ||
| .add(GET_ALL_DATABASES) | ||
| .add(GET_ALL_TABLES_FROM_DATABASE) | ||
| .addCopies(GET_TABLE, 3) |
There was a problem hiding this comment.
Small improvement might be to have one table that does not match the LIKE string and show that it does not need a GET_TABLE call.
|
|
||
| assertFileSystemAccesses("SELECT * FROM information_schema.columns WHERE table_name LIKE 'test_select_i_s_columns%'", | ||
| ImmutableMultiset.<FileOperation>builder() | ||
| .addCopies(new FileOperation(METADATA_JSON, INPUT_FILE_NEW_STREAM), 3) |
There was a problem hiding this comment.
Would be nice to show that if you have a table that does not match the filter we don't grab the metadata json file. Similarly a predicate on table_schema should filter the same way.
findepi
force-pushed
the
findepi/test-iceberg-operations-for-information-schema-columns-024444
branch
from
b923065 to
2210920
Compare
findepi
deleted the
findepi/test-iceberg-operations-for-information-schema-columns-024444
branch
losipiuk
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #18299