Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable buffering to disk for Azure output streams #18298

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

anusudarsan
Copy link
Member

apache/hadoop@acffe20 introduced logic to ABFS Output streams buffering blocks to disk (by default). This was introduced in Trino during Hadoop upgrade 343b908. We want to disable this and stick with the legacy behavior of keeping the blocks in memory

Description

Additional context and related issues

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Disable azure's buffer to disk functionality for output streams (write operations).

@cla-bot cla-bot bot added the cla-signed label Jul 14, 2023
@anusudarsan anusudarsan requested a review from electrum July 14, 2023 17:17
apache/hadoop@acffe20 introduced logic to ABFS Output streams buffering blocks to disk (by default).
This was introduced in Trino during Hadoop upgrade trinodb@343b908. We want to disable this and stick with the legacy behavior of keeping the blocks in memory
@anusudarsan anusudarsan force-pushed the my-trino/disable-azure-buffer branch from e17a4b8 to ea4bcb0 Compare July 14, 2023 17:19
@anusudarsan
Copy link
Member Author

@wendigo or @electrum can we merge this?

@wendigo wendigo merged commit 39458df into trinodb:master Jul 27, 2023
@github-actions github-actions bot added this to the 423 milestone Jul 27, 2023
@electrum
Copy link
Member

Thanks, I forgot to merge this after the release was completed.

@anusudarsan anusudarsan deleted the my-trino/disable-azure-buffer branch July 28, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants