Verify Delta, Iceberg do not call file length unnecessarily #18294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
test
no-release-notes
Improve `TrackingFileSystemFactory` (and thus `TestDeltaLakeFileOperations` and `TestIcebergMetadataFileOperations`) to correctly verify number of `INPUT_FILE_GET_LENGTH` calls.
Like in Delta, Iceberg. Prepare for file operations testing.
findepi
force-pushed
the
findepi/verify-delta-iceberg-do-not-call-file-length-unnecessarily-f7ca9d
branch
from
e5687ae to
60a712e
Compare
homar
approved these changes
Jul 14, 2023
alexjo2144
approved these changes
Jul 14, 2023
github-actions
bot
added
tests:hive
hudi
ebyhr
approved these changes
Jul 17, 2023
findepi
deleted the
findepi/verify-delta-iceberg-do-not-call-file-length-unnecessarily-f7ca9d
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve
TrackingFileSystemFactory(and thusTestDeltaLakeFileOperationsandTestIcebergMetadataFileOperations) to correctly verify number ofINPUT_FILE_GET_LENGTHcalls.