Deduplicate symbols inside GroupIdNode grouping set #18257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original grouping sets are deduplicated in the `StatementAnalyzer.Visitor.analyzeGroupBy`. Optimizer rules can create GroupIdNode that contain duplicates unintentionally though, for example, before `UnaliasSymbolReferences` rule is run, but LocalExecutionPlanner.Visitor.visitGroupId expects unique symbols in each grouping-set.
sopel39
approved these changes
Jul 13, 2023
sopel39
added
the
no-release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Original grouping sets are deduplicated in the
StatementAnalyzer.Visitor.analyzeGroupBy. Optimizer rules can create GroupIdNode that contain duplicates unintentionally though, for example, beforeUnaliasSymbolReferencesrule is run, but LocalExecutionPlanner.Visitor.visitGroupId expects unique symbols in each grouping-set.Additional context and related issues
Release notes
( X) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: