Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Iceberg MV failure after table roll back #18205

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Fix Iceberg MV failure after table roll back #18205

merged 2 commits into from
Jul 14, 2023

Conversation

findepi
Copy link
Member

@findepi findepi commented Jul 10, 2023

Fixes #18203

@findepi findepi added the iceberg Iceberg connector label Jul 10, 2023
@cla-bot cla-bot bot added the cla-signed label Jul 10, 2023
@findepi findepi force-pushed the findepi/iceberg-mv-snapshots branch from 104f480 to cc1bc1c Compare July 10, 2023 08:40
alexjo2144
alexjo2144 reviewed Jul 10, 2023
View reviewed changes
Copy link
Member

@alexjo2144 alexjo2144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you include a test that refreshes the MV after the rollback?

plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergUtil.java Show resolved Hide resolved
@findepi findepi force-pushed the findepi/iceberg-mv-snapshots branch from cc1bc1c to 0bbc949 Compare July 12, 2023 10:54
@findepi
Copy link
Member Author

findepi commented Jul 12, 2023

AC

@findepi findepi merged commit 7611313 into trinodb:master Jul 14, 2023
@findepi findepi deleted the findepi/iceberg-mv-snapshots branch July 14, 2023 13:59
@github-actions github-actions bot added this to the 423 milestone Jul 14, 2023
@colebow colebow mentioned this pull request Aug 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjo2144 alexjo2144 alexjo2144 approved these changes

@ebyhr ebyhr ebyhr approved these changes

@losipiuk losipiuk losipiuk approved these changes

@raunaqmorarka raunaqmorarka Awaiting requested review from raunaqmorarka

@findinpath findinpath Awaiting requested review from findinpath

Assignees
No one assigned
Labels
cla-signed iceberg Iceberg connector
Milestone
423
4 participants
@findepi @losipiuk @ebyhr @alexjo2144