Add opentracing to DistributedQueryRunner #18184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wendigo
requested review from
hashhar,
electrum,
kokosing,
nineinchnick and
elonazoulay
wendigo
force-pushed
the
serafin/query-runner-tracing
branch
2 times, most recently
from
f126b5d to
b3fddc6
Compare
nineinchnick
reviewed
Jul 8, 2023
testing/trino-testing/src/main/java/io/trino/testing/DistributedQueryRunner.java
Outdated
Show resolved
Hide resolved
wendigo
force-pushed
the
serafin/query-runner-tracing
branch
from
b3fddc6 to
c41993d
Compare
|
200.769 s to run HiveConnectorTest with TRACING=1 |
kokosing
approved these changes
Jul 11, 2023
nineinchnick
approved these changes
Jul 11, 2023
wendigo
force-pushed
the
serafin/query-runner-tracing
branch
from
c41993d to
ec724e6
Compare
This change makes it easier to access tracing information while using DistributedQueryRunners to work with tests. Tracing is disabled by default and can be enabled using environment variable TRACING=true or TRACING=1. When enabled, log message while be displayed on the console with the link to the query id trace search, i.e. ``` io.trino.testing.DistributedQueryRunner TRACING: 20230711_111250_05285_4dkkq :: http://localhost:52009/search?operation=query&service=trino&tags=%7B%22trino.query_id%22:%20%2220230711_111250_05285_4dkkq%22%7D ```
wendigo
force-pushed
the
serafin/query-runner-tracing
branch
from
ec724e6 to
85618c1
Compare
findepi
reviewed
Jul 14, 2023
...trino-testing-containers/src/main/java/io/trino/testing/containers/OpenTracingCollector.java
Show resolved
Hide resolved
findepi
reviewed
Jul 14, 2023
...trino-testing-containers/src/main/java/io/trino/testing/containers/OpenTracingCollector.java
Show resolved
Hide resolved
findepi
reviewed
Jul 14, 2023
testing/trino-testing/src/main/java/io/trino/testing/DistributedQueryRunner.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it easier to access tracing information while using
DistributedQueryRunner-s to work with tests.Trace search link is printed to the console so it's easier to access trace information directly:
The standard Jeager ui is used: