Expand docs for lexical structure #18181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosabua
force-pushed
the
docs-literals
branch
2 times, most recently
from
72b8915 to
959cf27
Compare
nineinchnick
reviewed
Jul 8, 2023
mosabua
changed the title
mosabua
force-pushed
the
docs-literals
branch
2 times, most recently
from
d9db4b9 to
f2c6afb
Compare
mosabua
changed the title
mosabua
force-pushed
the
docs-literals
branch
2 times, most recently
from
85aa88a to
851f3f0
Compare
nineinchnick
approved these changes
Aug 14, 2023
martint
reviewed
Aug 14, 2023
|
Addressed all feedback now. @nineinchnick can you check the values and also confirm this is still useful despite there being LOTS of digits now. @martint anything else I missed we should add or other feedback? |
nineinchnick
approved these changes
Aug 15, 2023
|
Any other requests @martint ? |
martint
reviewed
Aug 21, 2023
|
All updated apart from the question about REAL and DOUBLE |
|
Ping @martint |
martint
reviewed
Aug 29, 2023
- Add details about decimal, hexadecimal, octal, and binary literals - Add docs for comments - Add info about identifiers - Add info about underscore usage in literals Co-authored by: Manfred Moser <[email protected]>
|
Ping @martint |
martint
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Document lexical structure and add necessary updates to other pages. We should talk about how to proceed @martint since I believe the linked page for reserved keywords is also wrong by now and there are other things I have questions about how we want to document all this.
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: