Support updates when Delta table location has two trailing slashes #18177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findinpath
added
the
no-release-notes
github-actions
bot
added
tests:hive
delta-lake
findepi
reviewed
Jul 10, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/orc/OriginalFilesUtils.java
Outdated
Show resolved
Hide resolved
lib/trino-filesystem/src/main/java/io/trino/filesystem/Location.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/delta-merge-issue-double-slashes
branch
2 times, most recently
from
301df5b to
b82ce46
Compare
findepi
reviewed
Jul 10, 2023
lib/trino-filesystem/src/test/java/io/trino/filesystem/TestLocation.java
Show resolved
Hide resolved
lib/trino-filesystem/src/main/java/io/trino/filesystem/Location.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/test/java/io/trino/plugin/hive/BaseS3AndGlueMetastoreTest.java
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/orc/OriginalFilesUtils.java
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/delta-merge-issue-double-slashes
branch
from
b82ce46 to
89a8df1
Compare
findepi
changed the title
findepi
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alternative approach to #18155 for obtaining a sibling file location.
Fixes #17966
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: