Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Do not use hive.default as default catalog in product tests #18127

Closed
wants to merge 1 commit into from
Closed

[WIP] Do not use hive.default as default catalog in product tests #18127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...esources/docker/presto-product-tests/conf/tempto/tempto-configuration-for-docker-tls.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ databases:
http_port: 8080
https_port: ${databases.presto.port}
server_address: https://${databases.presto.host}:${databases.presto.port}
jdbc_url: "jdbc:trino://${databases.presto.host}:${databases.presto.port}/hive/${databases.hive.schema}?\
jdbc_url: "jdbc:trino://${databases.presto.host}:${databases.presto.port}?\
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
jdbc_url: "jdbc:trino://${databases.presto.host}:${databases.presto.port}?\
jdbc_url: "jdbc:trino://${databases.presto.host}:${databases.presto.port}/?\

?

SSL=true&\
SSLTrustStorePath=${databases.presto.https_keystore_path}&\
SSLTrustStorePassword=${databases.presto.https_keystore_password}"
Expand Down
2 changes: 1 addition & 1 deletion testing/trino-product-tests/src/main/resources/tempto-configuration.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ databases:
port: 8080
server_address: http://${databases.presto.host}:${databases.presto.port}
jdbc_driver_class: io.trino.jdbc.TrinoDriver
jdbc_url: jdbc:trino://${databases.presto.host}:${databases.presto.port}/hive/${databases.hive.schema}
jdbc_url: jdbc:trino://${databases.presto.host}:${databases.presto.port}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit?

Suggested change
jdbc_url: jdbc:trino://${databases.presto.host}:${databases.presto.port}
jdbc_url: jdbc:trino://${databases.presto.host}:${databases.presto.port}/

jdbc_user: hive
jdbc_password: "***empty***"
jdbc_pooling: false
Expand Down