Simplify array functions #18094
Merged
Simplify array functions #18094
+666
−1,016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Typo "BlockBuild" in first commit description |
electrum
approved these changes
Jun 30, 2023
core/trino-spi/src/main/java/io/trino/spi/function/ScalarFunctionAdapter.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/function/ScalarFunctionAdapter.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/function/ScalarFunctionAdapter.java
Show resolved
Hide resolved
core/trino-spi/src/test/java/io/trino/spi/function/TestScalarFunctionAdapter.java
Outdated
Show resolved
Hide resolved
core/trino-spi/src/main/java/io/trino/spi/function/OperatorType.java
Outdated
Show resolved
Hide resolved
| IS_POSITION_NULL = lookup().findVirtual(Block.class, "isNull", methodType(boolean.class, int.class)); | ||
| } | ||
| catch (ReflectiveOperationException e) { | ||
| throw new ExceptionInInitializerError(e); |
There was a problem hiding this comment.
We normally use AssertionError, but this seems better. We should probably switch to it for static initializers.
There was a problem hiding this comment.
I copied this from somewhere else, but I commonly see RuntimeException for these... we should pick one
| int position = toIntExact(index - 1); | ||
| if (array.isNull(position)) { | ||
| return null; | ||
| checkArrayIndex(index); |
There was a problem hiding this comment.
You can inline this now that there is only one usage. Also, consider converting to checkCondition
There was a problem hiding this comment.
This is actually referenced from the ExpressionInterpreter
core/trino-main/src/main/java/io/trino/operator/scalar/ArrayConcatFunction.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/scalar/ArrayRemoveFunction.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/operator/scalar/ArraySortComparatorFunction.java
Outdated
Show resolved
Hide resolved
dain
force-pushed
the
simplify-array-functions
branch
3 times, most recently
from
0b8c877 to
81c7b80
Compare
The BLOCK_BUILDER return convention writes the function result to a BlockBuilder which is passed as the last argument
dain
force-pushed
the
simplify-array-functions
branch
from
81c7b80 to
7b6a8c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BLOCK_BUILDERreturn convention that writes the result directly to aBlockBuilderREAD_VALUEoperator that can read a value from any argument convention to any return conventionPageBuildercache to use the simplerBufferedArrayValueBuilderRelease notes
(X) Release notes are required, with the following suggested text: