Restrict timestamp to varchar coercion for historical dates #18004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
force-pushed
the
praveen/restrict_timestamp_coercion_for_historical_dates
branch
from
c05a92a to
2d367c6
Compare
Hive 2.+ and Hive 3.+ uses `java.sql.Timestamp#toString` for coercing Timestamp to Varchar types. `java.sql.Timestamp#toString` doesn't capture the historical dates correctly
Praveen2112
force-pushed
the
praveen/restrict_timestamp_coercion_for_historical_dates
branch
from
2d367c6 to
338c363
Compare
Praveen2112
requested review from
atanasenko,
raunaqmorarka,
kokosing,
krvikash and
vlad-lyutenko
kokosing
approved these changes
Jul 14, 2023
atanasenko
approved these changes
Jul 14, 2023
krvikash
approved these changes
Jul 17, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/coercions/TimestampCoercer.java
Show resolved
Hide resolved
raunaqmorarka
approved these changes
Jul 21, 2023
vlad-lyutenko
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hive 2.+ and Hive 3.+ uses
java.sql.Timestamp#toStringfor coercing Timestampto Varchar types.
java.sql.Timestamp#toStringdoesn't capture the historical dates correctlyAdditional context and related issues
Depends on #18003
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: