Add test for S3 and Glue metastore #17930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
added
the
no-release-notes
1 task
findinpath
reviewed
Jun 16, 2023
plugin/trino-hive/src/test/java/io/trino/plugin/hive/TestHiveS3AndGlueMetastoreTest.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/hive-glue-s3-test2
branch
from
52e06ba to
5eee92f
Compare
findinpath
approved these changes
Jun 16, 2023
github-actions
bot
added
delta-lake
findepi
reviewed
Jun 16, 2023
findepi
approved these changes
Jun 16, 2023
Comment on lines
+293
to
+295
| // TODO https://github.com/trinodb/trino/issues/17803 Fix correctness issue with double slash | ||
| return super.locationPatterns().stream() | ||
| .filter(location -> !location.contains("double_slash")) |
There was a problem hiding this comment.
This is extracted from #17804
is this the only place that's different?
There was a problem hiding this comment.
This PR doesn't contain adaptTableLocation, testCreateTableWithDoubleSlash and testCtasWithDoubleSlash.
adaptTableLocationis an extension point when we run the test with HMS in the future.testCreateTableWithDoubleSlashandtestCtasWithDoubleSlashrequire some changes inHiveLocationService
There was a problem hiding this comment.
testCreateTableWithDoubleSlashandtestCtasWithDoubleSlashrequire some changes inHiveLocationService
or reverting de-hadooping of HiveLocationService?
Change AWS credential to use the same S3 bucket as other tests. Co-Authored-By: Slawomir Pajak <[email protected]>
ebyhr
force-pushed
the
ebi/hive-glue-s3-test2
branch
from
5eee92f to
b9cd773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add test for S3 and Glue metastore
Release notes
(x) This is not user-visible or docs only and no release notes are required.