Improve feedback from CI runs with all secrets #17927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting the CI run with all secrets, add a comment to the original PR with a link to that run, instead of only adding a comment after such run would fail. Update the comment with the status once it finishes.
|
/test-with-secrets sha=1a56bc8816812b48e715d655addb2d930cf7eefa Note: @nineinchnick told me we can't this change without merging PR. |
hashhar
approved these changes
Jun 16, 2023
Comment on lines
+95
to
+97
| if (comment.body === finished) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Looks unreachable. Even if you comment twice for same SHA two different runs will be started if the automation hasn't posted a comment yet
There was a problem hiding this comment.
This action is called from the test jobs created from a matrix, so there can be more than one. This is done to signal the original PR about the failure as early as possible.
There was a problem hiding this comment.
yes, in the body of this if block would make sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When starting the CI run with all secrets, add a comment to the original PR with a link to that run, instead of only adding a comment after such run would fail. Update the comment with the status once it finishes.
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: