Respect timestamp coercion when coercing complex column #17900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use == for enum comparison
Get type directly from HiveColumnHandle instead of generating them from HiveType.
Praveen2112
requested review from
findepi,
huberty89,
kokosing,
krvikash and
vlad-lyutenko
Praveen2112
force-pushed
the
praveen/timestamp_on_coerced_complex_column
branch
3 times, most recently
from
93da480 to
0631344
Compare
Praveen2112
force-pushed
the
praveen/timestamp_on_coerced_complex_column
branch
from
0631344 to
7cc5d79
Compare
Praveen2112
changed the title
Praveen2112
force-pushed
the
praveen/timestamp_on_coerced_complex_column
branch
from
7cc5d79 to
fd5118e
Compare
kokosing
approved these changes
Jun 22, 2023
| """ | ||
| INSERT INTO %s | ||
| SELECT | ||
| (CAST(ROW (timestamp_value, -1) AS ROW(keep TIMESTAMP(9), si2i SMALLINT))), |
There was a problem hiding this comment.
what is the point of si2i field?
There was a problem hiding this comment.
It is a non TIMESTAMP column which we are coercing so as to reproduce this issue
There was a problem hiding this comment.
But does the comment help here - in the next set of PRs we would be adding additional column like timestamp which will be coerced.
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HivePageSourceProvider.java
Show resolved
Hide resolved
krvikash
approved these changes
Jun 22, 2023
| @@ -108,6 +129,21 @@ private static HiveTableDefinition.HiveTableDefinitionBuilder tableDefinitionBui | |||
| "STORED AS " + fileFormat); | |||
| } | |||
|
|
|||
| private static HiveTableDefinition.HiveTableDefinitionBuilder tableDefinitionForTimestampCoercionBuilder(String fileFormat, Optional<String> recommendTableName, Optional<String> rowFormat) | |||
There was a problem hiding this comment.
maybe recommendTableName -> tableNamePrefix?
| " timestamp_map_to_map MAP<SMALLINT, STRUCT<keep: TIMESTAMP, si2i: SMALLINT>>" + | ||
| ") " + | ||
| "PARTITIONED BY (id BIGINT) " + | ||
| rowFormat.map(s -> format("ROW FORMAT %s ", s)).orElse("") + |
There was a problem hiding this comment.
I wanted to have a unified representation across this class.
Comment on lines
+398
to
+400
| onHive().executeQuery(format("ALTER TABLE %s CHANGE COLUMN timestamp_row_to_row timestamp_row_to_row struct<keep:timestamp, si2i:int>", tableName)); | ||
| onHive().executeQuery(format("ALTER TABLE %s CHANGE COLUMN timestamp_list_to_list timestamp_list_to_list array<struct<keep:timestamp, si2i:int>>", tableName)); | ||
| onHive().executeQuery(format("ALTER TABLE %s CHANGE COLUMN timestamp_map_to_map timestamp_map_to_map map<int,struct<keep:timestamp, si2i:int>>", tableName)); |
There was a problem hiding this comment.
nit: uppercase data types?
There was a problem hiding this comment.
I was thinking on handling it as a follow-up once the changes related to coercion are implemented. WDYT ?
Previously MILLISECONDS precision was leaked when corecion applied on complex column even if coercion was not applied on timestamp column.
Praveen2112
force-pushed
the
praveen/timestamp_on_coerced_complex_column
branch
from
fd5118e to
a538773
Compare
|
@krvikash AC |
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HivePageSourceProvider.java
Show resolved
Hide resolved
vlad-lyutenko
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously MILLISECONDS precision was leaked when corecion applied on complex column even if coercion was not applied on timestamp column.
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: