Test product tests launcher #17875
Merged
Test product tests launcher #17875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one is for you @kokosing 😇 |
wendigo
force-pushed
the
serafin/ptl-testing
branch
from
c9cf747 to
ccbfad7
Compare
kokosing
approved these changes
Jun 14, 2023
...ct-tests-launcher/src/main/java/io/trino/tests/product/launcher/cli/EnvironmentDescribe.java
Show resolved
Hide resolved
...uct-tests-launcher/src/main/java/io/trino/tests/product/launcher/env/EnvironmentOptions.java
Outdated
Show resolved
Hide resolved
|
Nice! |
This parameter is null by default and is only initialized by picocli when the command is invoked.
This prevents regressions where some of the invocations are broken because of the lack of the dependencies or null derefences.
wendigo
force-pushed
the
serafin/ptl-testing
branch
from
ccbfad7 to
d01c513
Compare
kokosing
approved these changes
Jun 14, 2023
| @@ -232,7 +230,7 @@ public Execution( | |||
| this.outputBuilder = describeOptions.format.outputBuilderFactory.get(); | |||
|
|
|||
| try { | |||
| this.out = new PrintStream(new FileOutputStream(FileDescriptor.out), true, Charset.defaultCharset().name()); | |||
| this.out = new PrintStream(System.out, true, Charset.defaultCharset().name()); | |||
There was a problem hiding this comment.
I think this is causing to actually write to stderr because of https://github.com/airlift/airlift/blob/master/log-manager/src/main/java/io/airlift/log/Logging.java#L139
This commit should be reverted. Logging to stderr here makes this fail to read any output: https://github.com/trinodb/trino/blob/master/.github/bin/build-pt-matrix-from-impacted-connectors.py#L108
and in result we're always running all PTs in PRs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #17873