Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove unnecessary separate CI job for Redshift" #17824

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

hashhar
Copy link
Member

@hashhar hashhar commented Jun 9, 2023

Description

This reverts commit dc8d3fa.

The job is not unnecessary since the default profile includes all tests which don't need Redshift - TestRedshiftConfig, TestRedshiftPlugin etc.

Release notes

(x) This is not user-visible or docs only and no release notes are required.

@hashhar hashhar requested review from findepi, ebyhr and kokosing June 9, 2023 10:03
@cla-bot cla-bot bot added the cla-signed label Jun 9, 2023
This reverts commit dc8d3fa.

The job is not unnecessary since the default profile includes all tests
which don't need a running Redshift instance - `TestRedshiftConfig`,
`TestRedshiftPlugin` etc.
@hashhar hashhar force-pushed the hashhar/restore-redshift-ci branch from fb59b1c to dcc3853 Compare June 9, 2023 10:03
@hashhar
Copy link
Member Author

hashhar commented Jun 9, 2023

CI hit #16277

@hashhar hashhar merged commit bed8cc3 into master Jun 9, 2023
@hashhar hashhar deleted the hashhar/restore-redshift-ci branch June 9, 2023 13:07
@github-actions github-actions bot added this to the 420 milestone Jun 9, 2023
@findepi
Copy link
Member

findepi commented Jun 12, 2023

@hashhar i think dc8d3fa was fine.
after that change, the trino-redshift's default profile was being run as part of other tests.
the commit didn't -- IMO -- remove test coverage. it removed separate CI job/task for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants